From: Steven Dake <sdake@mvista.com>
To: linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: [PATCH} fix defect with kobject memory leaks during del_gendisk
Date: Wed, 24 Sep 2003 16:02:06 -0700 [thread overview]
Message-ID: <1064444526.13033.355.camel@persist.az.mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Folks,
Attached is a patch which fixes a few memory leaks in 2.6.0-test5.
Comments are welcome as to whether or not this patch is the right
solution.
I added the ability to linux MD to generate add and remove hotplug calls
on RAID START and STOPs. To achieve this, I use the del_gendisk call
which deletes the gendisk, delete the children kobjects, and delete the
parent (in this case, mdX) kobject.
Unfortunately it appears that del_gendisk uses kobject_del to delete the
kobject. If the kobject has a ktype release function, it is not called
in the kobject_del call path, but only in kobject_unregister.
This patch changes the functionality so the release function (in this
case the block device release function in drivers/block/genhd.c) is
called by changing the kobject_del to kobject_unregister.
Without this patch, at least 3 memory leaks occur on removal of a block
device using the del_gendisk function.
Thanks
-steve
[-- Attachment #2: fix_del_gendisk_kobj.patch --]
[-- Type: text/plain, Size: 337 bytes --]
--- linux-2.6.0-test5/fs/partitions/check.c 2003-09-08 12:50:28.000000000 -0700
+++ linux-fixmd/fs/partitions/check.c 2003-09-24 15:28:57.000000000 -0700
@@ -458,5 +458,5 @@
sysfs_remove_link(&disk->driverfs_dev->kobj, "block");
put_device(disk->driverfs_dev);
}
- kobject_del(&disk->kobj);
+ kobject_unregister(&disk->kobj);
}
next reply other threads:[~2003-09-24 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 23:02 Steven Dake [this message]
2003-09-25 6:23 ` Christoph Hellwig
2003-09-25 18:04 ` Steven Dake
2003-09-25 17:26 ` Patrick Mochel
2003-09-25 18:43 ` Steven Dake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064444526.13033.355.camel@persist.az.mvista.com \
--to=sdake@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®