From: Steven Dake <sdake@mvista.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH} fix defect with kobject memory leaks during del_gendisk
Date: Thu, 25 Sep 2003 11:04:11 -0700 [thread overview]
Message-ID: <1064513050.4763.21.camel@persist.az.mvista.com> (raw)
In-Reply-To: <20030925072343.A4636@infradead.org>
On Wed, 2003-09-24 at 23:23, Christoph Hellwig wrote:
> On Wed, Sep 24, 2003 at 04:02:06PM -0700, Steven Dake wrote:
> > Unfortunately it appears that del_gendisk uses kobject_del to delete the
> > kobject. If the kobject has a ktype release function, it is not called
> > in the kobject_del call path, but only in kobject_unregister.
>
> That's intentional. gendisks (like everything using kobjects) are
> reference counted and ->release is unly called after the last reference
> goes away, for gendisks that would be the last put_disk call.
>
> Unless you miss the put_disk call (which md certainly has) there's
> no memeory leak.
>
Thanks Christoph...
Looks like I'm barking up the wrong tree. Time to go fix up md :)
-steve
>
next prev parent reply other threads:[~2003-09-25 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 23:02 Steven Dake
2003-09-25 6:23 ` Christoph Hellwig
2003-09-25 18:04 ` Steven Dake [this message]
2003-09-25 17:26 ` Patrick Mochel
2003-09-25 18:43 ` Steven Dake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064513050.4763.21.camel@persist.az.mvista.com \
--to=sdake@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®