From: James Bottomley <James.Bottomley@steeleye.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix smc-mca cleanup breakage
Date: 25 Sep 2003 15:40:27 -0500 [thread overview]
Message-ID: <1064522429.1781.21.camel@mulgrave> (raw)
The latest set of smc-mca fixes broke the driver. Apparently, it wasn't
realised that request_region() actually returns a pointer to the region
you're requesting if it can. Without this fix, the smc-mca cannot
attach to any device.
James
===== drivers/net/smc-mca.c 1.11 vs edited =====
--- 1.11/drivers/net/smc-mca.c Thu Sep 4 02:36:29 2003
+++ edited/drivers/net/smc-mca.c Thu Sep 25 15:26:14 2003
@@ -269,9 +269,10 @@
goto err_unregister_netdev;
}
- rc = request_region(ioaddr, ULTRA_IO_EXTENT, dev->name);
- if (rc)
+ if (!request_region(ioaddr, ULTRA_IO_EXTENT, dev->name)) {
+ rc = -ENODEV;
goto err_unregister_netdev;
+ }
reg4 = inb(ioaddr + 4) & 0x7f;
outb(reg4, ioaddr + 4);
reply other threads:[~2003-09-25 20:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064522429.1781.21.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®