* [PATCH] fix smc-mca cleanup breakage
@ 2003-09-25 20:40 James Bottomley
0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2003-09-25 20:40 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel
The latest set of smc-mca fixes broke the driver. Apparently, it wasn't
realised that request_region() actually returns a pointer to the region
you're requesting if it can. Without this fix, the smc-mca cannot
attach to any device.
James
===== drivers/net/smc-mca.c 1.11 vs edited =====
--- 1.11/drivers/net/smc-mca.c Thu Sep 4 02:36:29 2003
+++ edited/drivers/net/smc-mca.c Thu Sep 25 15:26:14 2003
@@ -269,9 +269,10 @@
goto err_unregister_netdev;
}
- rc = request_region(ioaddr, ULTRA_IO_EXTENT, dev->name);
- if (rc)
+ if (!request_region(ioaddr, ULTRA_IO_EXTENT, dev->name)) {
+ rc = -ENODEV;
goto err_unregister_netdev;
+ }
reg4 = inb(ioaddr + 4) & 0x7f;
outb(reg4, ioaddr + 4);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-09-25 20:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-25 20:40 [PATCH] fix smc-mca cleanup breakage James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®