From: Bernadette SING <bernadette.sing@laposte.net>
To: linux-kernel@vger.kernel.org
Subject: [TRIVIAL PATCH] superfluous assignement in ide_diag_taskfile()
Date: Tue, 23 Dec 2003 16:28:02 +0100 [thread overview]
Message-ID: <1072193271.4456.11.camel@silenus.home> (raw)
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
Hi,
>From ide_diag_taskfile()
ide_init_drive_taskfile(&rq);
rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;
but in ide_init_drive_taskfile() we've got:
void ide_init_drive_taskfile (struct request *rq)
{
memset(rq, 0, sizeof(*rq));
rq->flags = REQ_DRIVE_TASKFILE;
}
The REQ_DRIVE_TASKFILE assignement in ide_diag_taskfile() looks
superfluous.
Patch attached.
--
Frederik DEWEERDT
[-- Attachment #2: patch.ide-taskfile_c.cleanup --]
[-- Type: text/plain, Size: 297 bytes --]
--- /usr/src/linux-2.6.0/drivers/ide/ide-taskfile.c 2003-12-18 15:41:19.000000000 +0100
+++ linux/drivers/ide/ide-taskfile.c 2003-12-22 11:12:06.000000000 +0100
@@ -1372,7 +1372,6 @@
struct request rq;
ide_init_drive_taskfile(&rq);
- rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;
/*
reply other threads:[~2003-12-23 15:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072193271.4456.11.camel@silenus.home \
--to=bernadette.sing@laposte.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®