* [TRIVIAL PATCH] superfluous assignement in ide_diag_taskfile()
@ 2003-12-23 15:28 Bernadette SING
0 siblings, 0 replies; only message in thread
From: Bernadette SING @ 2003-12-23 15:28 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
Hi,
>From ide_diag_taskfile()
ide_init_drive_taskfile(&rq);
rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;
but in ide_init_drive_taskfile() we've got:
void ide_init_drive_taskfile (struct request *rq)
{
memset(rq, 0, sizeof(*rq));
rq->flags = REQ_DRIVE_TASKFILE;
}
The REQ_DRIVE_TASKFILE assignement in ide_diag_taskfile() looks
superfluous.
Patch attached.
--
Frederik DEWEERDT
[-- Attachment #2: patch.ide-taskfile_c.cleanup --]
[-- Type: text/plain, Size: 297 bytes --]
--- /usr/src/linux-2.6.0/drivers/ide/ide-taskfile.c 2003-12-18 15:41:19.000000000 +0100
+++ linux/drivers/ide/ide-taskfile.c 2003-12-22 11:12:06.000000000 +0100
@@ -1372,7 +1372,6 @@
struct request rq;
ide_init_drive_taskfile(&rq);
- rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;
/*
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-12-23 15:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-23 15:28 [TRIVIAL PATCH] superfluous assignement in ide_diag_taskfile() Bernadette SING
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®