From: Arjan van de Ven <arjanv@redhat.com>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Jon Smirl <jonsmirl@yahoo.com>,
dri-devel <dri-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Dri-devel] 2.6 kernel change in nopage
Date: Thu, 01 Jan 2004 13:10:55 +0100 [thread overview]
Message-ID: <1072959055.5717.1.camel@laptop.fenrus.com> (raw)
In-Reply-To: <1072958618.1603.236.camel@thor.asgaard.local>
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
On Thu, 2004-01-01 at 13:03, Michel Dänzer wrote:
> How does this patch look?
ugly.
I find using #defines for function arguments ugly beyond belief and
makes it really hard to look through code. I 10x rather have an ifdef in
the function prototype (which then for the mainstream kernel drm can be
removed for non-matching versions) than such obfuscation.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-01-01 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031231182148.26486.qmail@web14918.mail.yahoo.com>
2004-01-01 12:03 ` Michel Dänzer
2004-01-01 12:10 ` Arjan van de Ven [this message]
2004-01-01 12:23 ` Michel Dänzer
2004-01-01 12:28 ` Arjan van de Ven
2004-01-01 14:27 ` Michel Dänzer
2004-01-01 15:06 ` William Lee Irwin III
2004-01-01 20:19 ` Linus Torvalds
2004-01-01 20:57 ` Nigel Cunningham
2004-01-01 22:57 ` Linus Torvalds
2004-01-10 21:54 ` Michel Dänzer
2004-01-10 22:08 ` Arjan van de Ven
2004-01-11 0:15 ` Michel Dänzer
2004-01-01 13:33 ` William Lee Irwin III
2004-01-01 13:50 ` Michel Dänzer
2004-01-01 14:13 ` William Lee Irwin III
2004-01-01 17:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072959055.5717.1.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=jonsmirl@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®