mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: dsterba@suse.cz
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning
Date: Fri, 3 Oct 2025 16:21:17 +0100	[thread overview]
Message-ID: <10762d3f-361a-48b7-8e46-5e5b8a9887fb@embeddedor.com> (raw)
In-Reply-To: <20251003151509.GK4052@suse.cz>



On 10/3/25 16:15, David Sterba wrote:
> On Fri, Oct 03, 2025 at 03:51:24PM +0100, Gustavo A. R. Silva wrote:
>>>>
>>>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
>>>> index 9230e5066fc6..2b7cf49a35bb 100644
>>>> --- a/fs/btrfs/send.c
>>>> +++ b/fs/btrfs/send.c
>>>> @@ -178,7 +178,6 @@ struct send_ctx {
>>>>    	u64 cur_inode_rdev;
>>>>    	u64 cur_inode_last_extent;
>>>>    	u64 cur_inode_next_write_offset;
>>>> -	struct fs_path cur_inode_path;
>>>>    	bool cur_inode_new;
>>>>    	bool cur_inode_new_gen;
>>>>    	bool cur_inode_deleted;
>>>> @@ -305,6 +304,9 @@ struct send_ctx {
>>>>    
>>>>    	struct btrfs_lru_cache dir_created_cache;
>>>>    	struct btrfs_lru_cache dir_utimes_cache;
>>>> +
>>>> +	/* Must be last --ends in a flexible-array member. */
>>>                           ^^
>>>
>>> Is this an en dash?
>>
>> Not sure what you mean.
> 
> En dash is a punctuation mark not typically used in comments, nowadays
> found in AI generated code/text. I was just curious.

Ah yes, I've been using this punctuation mark for this sorts of comments,
but this is not AI generated code/text.

-Gustavo


  reply	other threads:[~2025-10-03 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-03 14:11 Gustavo A. R. Silva
2025-10-03 14:35 ` David Sterba
2025-10-03 14:51   ` Gustavo A. R. Silva
2025-10-03 15:15     ` David Sterba
2025-10-03 15:21       ` Gustavo A. R. Silva [this message]
2025-10-06 16:06         ` David Sterba
2025-10-06 17:23 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10762d3f-361a-48b7-8e46-5e5b8a9887fb@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=gustavoars@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®