From: David Sterba <dsterba@suse.cz>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: dsterba@suse.cz, "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning
Date: Mon, 6 Oct 2025 18:06:01 +0200 [thread overview]
Message-ID: <20251006160601.GA4412@twin.jikos.cz> (raw)
In-Reply-To: <10762d3f-361a-48b7-8e46-5e5b8a9887fb@embeddedor.com>
On Fri, Oct 03, 2025 at 04:21:17PM +0100, Gustavo A. R. Silva wrote:
> On 10/3/25 16:15, David Sterba wrote:
> > On Fri, Oct 03, 2025 at 03:51:24PM +0100, Gustavo A. R. Silva wrote:
> >>>>
> >>>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> >>>> index 9230e5066fc6..2b7cf49a35bb 100644
> >>>> --- a/fs/btrfs/send.c
> >>>> +++ b/fs/btrfs/send.c
> >>>> @@ -178,7 +178,6 @@ struct send_ctx {
> >>>> u64 cur_inode_rdev;
> >>>> u64 cur_inode_last_extent;
> >>>> u64 cur_inode_next_write_offset;
> >>>> - struct fs_path cur_inode_path;
> >>>> bool cur_inode_new;
> >>>> bool cur_inode_new_gen;
> >>>> bool cur_inode_deleted;
> >>>> @@ -305,6 +304,9 @@ struct send_ctx {
> >>>>
> >>>> struct btrfs_lru_cache dir_created_cache;
> >>>> struct btrfs_lru_cache dir_utimes_cache;
> >>>> +
> >>>> + /* Must be last --ends in a flexible-array member. */
> >>> ^^
> >>>
> >>> Is this an en dash?
> >>
> >> Not sure what you mean.
> >
> > En dash is a punctuation mark not typically used in comments, nowadays
> > found in AI generated code/text. I was just curious.
>
> Ah yes, I've been using this punctuation mark for this sorts of comments,
It's quite odd to see it formatted like that, it's confusing and looks
like a typo. The emdash "---" looks like the right punct. mark as it
separates extra information, if we'd want to delve into typographical
conventions.
next prev parent reply other threads:[~2025-10-06 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 14:11 Gustavo A. R. Silva
2025-10-03 14:35 ` David Sterba
2025-10-03 14:51 ` Gustavo A. R. Silva
2025-10-03 15:15 ` David Sterba
2025-10-03 15:21 ` Gustavo A. R. Silva
2025-10-06 16:06 ` David Sterba [this message]
2025-10-06 17:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006160601.GA4412@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®