mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: Vaibhav Nagare <nagarevaibhav@gmail.com>, justin.tee@broadcom.com
Cc: James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Vaibhav Nagare <vnagare@redhat.com>,
	"paul.ely@broadcom.com" <paul.ely@broadcom.com>
Subject: Re: [PATCH v2] scsi: lpfc: Add rport validation in lpfc_dev_loss_tmo_callbk
Date: Tue, 30 Jun 2026 12:12:09 -0700	[thread overview]
Message-ID: <10777a10-c65c-4dd0-b4ba-00d94351aaf1@gmail.com> (raw)
In-Reply-To: <20260629190108.601212-1-vnagare@redhat.com>

Hi Vaibhav,

1.) This patch looks like it was rebased on top of the first version of 
this patch instead of off the tree.

2.) lpfc_dev_loss_tmo_callbk is the .dev_loss_tmo_callbk routine for 
scsi transport layer to call into our driver when dev_loss_tmo event is 
detected.  A null ndlp->vport in lpfc_dev_loss_tmo_callbk is somewhat 
unexpected.  Rather than checking for a stale pointer, it is more likely 
that an ndlp kref accounting race caused the vport ptr to be freed 
before lpfc_dev_loss_tmo_callbk was called.

Is it possible to share the vmcore’s dmesg.txt file so that we may 
examine the root cause of the stale ndlp->vport ptr?

Regards,
Justin

  reply	other threads:[~2026-06-30 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 19:01 Vaibhav Nagare
2026-06-30 19:12 ` Justin Tee [this message]
2026-07-01 12:27 ` Ewan Milne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10777a10-c65c-4dd0-b4ba-00d94351aaf1@gmail.com \
    --to=justintee8345@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=justin.tee@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nagarevaibhav@gmail.com \
    --cc=paul.ely@broadcom.com \
    --cc=vnagare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome