mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] missing put in AFS client
@ 2002-10-18  8:06 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2002-10-18  8:06 UTC (permalink / raw)
  To: torvalds; +Cc: Chris Wright, linux-kernel


Hi Linus,

This patch fixes a bug in my AFS client in which a put of an outstanding call
was missing in the unmount cleanup code. This occasionally resulted in the AFS
module becoming unremovable.

David

diff -ur -x '*.o' -x '*.cmd' -x '*~' linux-2.5.43/fs/afs/cmservice.c afs-devel/fs/afs/cmservice.c
--- linux-2.5.43/fs/afs/cmservice.c	2002-10-16 09:25:59.000000000 +0100
+++ afs-devel/fs/afs/cmservice.c	2002-10-18 08:57:44.000000000 +0100
@@ -129,11 +129,7 @@
 	/* only certain signals are of interest */
 	spin_lock_irq(&current->sig->siglock);
 	siginitsetinv(&current->blocked,0);
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,3)
 	recalc_sigpending();
-#else
-	recalc_sigpending(current);
-#endif
 	spin_unlock_irq(&current->sig->siglock);
 
 	/* loop around looking for things to attend to */
@@ -360,6 +356,9 @@
 
 			rxrpc_call_abort(call,-ESRCH); /* abort, dequeue and put */
 
+			_debug("nuking active call %08x.%d",
+			       ntohl(call->conn->conn_id),ntohl(call->call_id));
+			rxrpc_put_call(call);
 			rxrpc_put_call(call);
 
 			spin_lock(&afscm_calls_lock);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-10-18  8:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-18  8:06 [PATCH] missing put in AFS client David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®