mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* "PowerMac IDE DMA support"
@ 2004-05-06 17:39 Nicolas Vollmar
  2004-05-07  1:04 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Vollmar @ 2004-05-06 17:39 UTC (permalink / raw)
  To: Kernel Mailing List; +Cc: Linus Torvalds

Hi

I tried to compile a new Kernel on my iBook and get a compile Error from the 
IDE PMAC Driver. I had some time to find out that "Generic PCI bus-master DMA 
support" is needed to compile cleanly.

It may be better if BLK_DEV_IDEDMA_PMAC depends on BLK_DEV_IDEDMA_PCI?

mfg
Nicolas Vollmar


diff -Nru linux-2.6.5-rc3/drivers/ide/Kconfig 
linux-2.6.5-rc3-1/drivers/ide/Kconfig
--- linux-2.6.5-rc3/drivers/ide/Kconfig	2004-04-04 03:37:06.000000000 +0000
+++ linux-2.6.5-rc3-1/drivers/ide/Kconfig	2004-05-06 17:17:45.225351696 +0000
@@ -826,7 +826,7 @@
 
 config BLK_DEV_IDEDMA_PMAC
 	bool "PowerMac IDE DMA support"
-	depends on BLK_DEV_IDE_PMAC
+	depends on BLK_DEV_IDE_PMAC && BLK_DEV_IDEDMA_PCI
 	help
 	  This option allows the driver for the built-in IDE controller on
 	  Power Macintoshes and PowerBooks to use DMA (direct memory access)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: "PowerMac IDE DMA support"
  2004-05-06 17:39 "PowerMac IDE DMA support" Nicolas Vollmar
@ 2004-05-07  1:04 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2004-05-07  1:04 UTC (permalink / raw)
  To: Nicolas Vollmar; +Cc: Kernel Mailing List, Linus Torvalds

On Fri, 2004-05-07 at 03:39, Nicolas Vollmar wrote:
> Hi
> 
> I tried to compile a new Kernel on my iBook and get a compile Error from the 
> IDE PMAC Driver. I had some time to find out that "Generic PCI bus-master DMA 
> support" is needed to compile cleanly.
> 
> It may be better if BLK_DEV_IDEDMA_PMAC depends on BLK_DEV_IDEDMA_PCI?

I think the problem is that some of the generic IDE DMA code shouldn't be
under BLK_DEV_IDEDMA_PCI ... It 's used by several non-strictly-PCI
controllers like this one. (Some non-PCI at all). 

Ben.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-07  1:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-06 17:39 "PowerMac IDE DMA support" Nicolas Vollmar
2004-05-07  1:04 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®