* [PATCH 2.6.6-mm4] ring_info spinlock initialization
@ 2004-05-21 19:18 FabF
2004-05-21 20:12 ` Zwane Mwaikambo
0 siblings, 1 reply; 4+ messages in thread
From: FabF @ 2004-05-21 19:18 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 75 bytes --]
Hi,
ring_info spinlock was not initialized in INIT_KIOCTX.
Regards,
FabF
[-- Attachment #2: inittask1.diff --]
[-- Type: text/x-patch, Size: 400 bytes --]
diff -Naur orig/include/linux/init_task.h edited/include/linux/init_task.h
--- orig/include/linux/init_task.h 2004-05-10 04:32:00.000000000 +0200
+++ edited/include/linux/init_task.h 2004-05-21 14:26:56.000000000 +0200
@@ -29,6 +29,7 @@
.ctx_lock = SPIN_LOCK_UNLOCKED, \
.reqs_active = 0U, \
.max_reqs = ~0U, \
+ .ring_info.ring_lock = SPIN_LOCK_UNLOCKED \
}
#define INIT_MM(name) \
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.6-mm4] ring_info spinlock initialization
2004-05-21 19:18 [PATCH 2.6.6-mm4] ring_info spinlock initialization FabF
@ 2004-05-21 20:12 ` Zwane Mwaikambo
2004-05-21 20:38 ` FabF
2004-05-22 9:21 ` FabF
0 siblings, 2 replies; 4+ messages in thread
From: Zwane Mwaikambo @ 2004-05-21 20:12 UTC (permalink / raw)
To: FabF; +Cc: linux-kernel
On Fri, 21 May 2004, FabF wrote:
> Hi,
> ring_info spinlock was not initialized in INIT_KIOCTX.
Shouldn't something have caught that?
Zwane
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.6-mm4] ring_info spinlock initialization
2004-05-21 20:12 ` Zwane Mwaikambo
@ 2004-05-21 20:38 ` FabF
2004-05-22 9:21 ` FabF
1 sibling, 0 replies; 4+ messages in thread
From: FabF @ 2004-05-21 20:38 UTC (permalink / raw)
To: Zwane Mwaikambo; +Cc: linux-kernel
On Fri, 2004-05-21 at 22:12, Zwane Mwaikambo wrote:
> On Fri, 21 May 2004, FabF wrote:
>
> > Hi,
> > ring_info spinlock was not initialized in INIT_KIOCTX.
>
> Shouldn't something have caught that?
aio stuff is the only place which doesn't use INIT_KIOCTX and does
explicitely that initialization so I guess this patch is needed ...
>
> Zwane
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.6-mm4] ring_info spinlock initialization
2004-05-21 20:12 ` Zwane Mwaikambo
2004-05-21 20:38 ` FabF
@ 2004-05-22 9:21 ` FabF
1 sibling, 0 replies; 4+ messages in thread
From: FabF @ 2004-05-22 9:21 UTC (permalink / raw)
To: Zwane Mwaikambo; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On Fri, 2004-05-21 at 22:12, Zwane Mwaikambo wrote:
> On Fri, 21 May 2004, FabF wrote:
>
> > Hi,
> > ring_info spinlock was not initialized in INIT_KIOCTX.
>
> Shouldn't something have caught that?
Zwane,
Did you find something about that thread ? I don't see anything
relevant in mm5 :(
Regards,
FabF
>
> Zwane
>
>
[-- Attachment #2: inittask1.diff --]
[-- Type: text/x-patch, Size: 400 bytes --]
diff -Naur orig/include/linux/init_task.h edited/include/linux/init_task.h
--- orig/include/linux/init_task.h 2004-05-10 04:32:00.000000000 +0200
+++ edited/include/linux/init_task.h 2004-05-21 14:26:56.000000000 +0200
@@ -29,6 +29,7 @@
.ctx_lock = SPIN_LOCK_UNLOCKED, \
.reqs_active = 0U, \
.max_reqs = ~0U, \
+ .ring_info.ring_lock = SPIN_LOCK_UNLOCKED \
}
#define INIT_MM(name) \
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-05-22 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-21 19:18 [PATCH 2.6.6-mm4] ring_info spinlock initialization FabF
2004-05-21 20:12 ` Zwane Mwaikambo
2004-05-21 20:38 ` FabF
2004-05-22 9:21 ` FabF
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®