[PATCH] fix dependeces for CONFIG_USB_STORAGE

[PATCH] fix dependeces for CONFIG_USB_STORAGE

[Paolo Ornati]

This patch adds a missed dependence for CONFIG_USB_STORAGE.

Signed-off-by: Paolo Ornati <ornati@fastwebnet.it>

--- linux/drivers/usb/storage/Kconfig.orig	2004-06-02 10:55:18.000000000 +0200
+++ linux/drivers/usb/storage/Kconfig	2004-06-02 10:56:03.000000000 +0200
@@ -6,6 +6,7 @@
 	tristate "USB Mass Storage support"
 	depends on USB
 	select SCSI
+	select BLK_DEV_SD
 	---help---
 	  Say Y here if you want to connect USB mass storage devices to your
 	  computer's USB port. This is the driver you need for USB floppy drives,


-- 
	Paolo Ornati
	Linux v2.6.6

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Christoph Hellwig]

On Wed, Jun 02, 2004 at 11:16:35AM +0200, Paolo Ornati wrote:
> This patch adds a missed dependence for CONFIG_USB_STORAGE.
> 
> Signed-off-by: Paolo Ornati <ornati@fastwebnet.it>
> 
> --- linux/drivers/usb/storage/Kconfig.orig	2004-06-02 10:55:18.000000000 +0200
> +++ linux/drivers/usb/storage/Kconfig	2004-06-02 10:56:03.000000000 +0200
> @@ -6,6 +6,7 @@
>  	tristate "USB Mass Storage support"
>  	depends on USB
>  	select SCSI
> +	select BLK_DEV_SD

Huh, why?

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Christoph Hellwig]

On Wed, Jun 02, 2004 at 01:52:14PM +0200, Paolo Ornati wrote:
> So if you want to use USB Mass Storage devices (that use SCSI emulation) you 
> need also SCSI disk support (I have realized it when I've tried to mount 
> one those USB devices, without success).

There's also external usb cdrom enclosures.  In which case you only need
sr.

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Paolo Ornati]

On Wednesday 02 June 2004 12:49, Christoph Hellwig wrote:
> On Wed, Jun 02, 2004 at 11:16:35AM +0200, Paolo Ornati wrote:
> > This patch adds a missed dependence for CONFIG_USB_STORAGE.
> >
> > Signed-off-by: Paolo Ornati <ornati@fastwebnet.it>
> >
> > --- linux/drivers/usb/storage/Kconfig.orig	2004-06-02
> > 10:55:18.000000000 +0200 +++
> > linux/drivers/usb/storage/Kconfig	2004-06-02 10:56:03.000000000 +0200
> > @@ -6,6 +6,7 @@
> >  	tristate "USB Mass Storage support"
> >  	depends on USB
> >  	select SCSI
> > +	select BLK_DEV_SD
>
> Huh, why?

This HELP (taken from linux/drivers/scsi/Kconfig) is quite explicit:

config BLK_DEV_SD
        tristate "SCSI disk support"
        depends on SCSI
        ---help---
          If you want to use SCSI hard disks, Fibre Channel disks,
          USB storage or the SCSI or parallel port version of
          the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
          the Disk-HOWTO and the Multi-Disk-HOWTO, available from
          <http://www.tldp.org/docs.html#howto>. This is NOT for SCSI
          CD-ROMs.

So if you want to use USB Mass Storage devices (that use SCSI emulation) you 
need also SCSI disk support (I have realized it when I've tried to mount 
one those USB devices, without success).

Bye,

-- 
	Paolo Ornati
	Linux v2.6.6

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Oliver Neukum]

> > Huh, why?
> 
> This HELP (taken from linux/drivers/scsi/Kconfig) is quite explicit:
> 
> config BLK_DEV_SD
>         tristate "SCSI disk support"
>         depends on SCSI
>         ---help---
>           If you want to use SCSI hard disks, Fibre Channel disks,
>           USB storage or the SCSI or parallel port version of
>           the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
>           the Disk-HOWTO and the Multi-Disk-HOWTO, available from
>           <http://www.tldp.org/docs.html#howto>. This is NOT for SCSI
>           CD-ROMs.
> 
> So if you want to use USB Mass Storage devices (that use SCSI emulation) you 
> need also SCSI disk support (I have realized it when I've tried to mount 
> one those USB devices, without success).

The help text is misleading. You need SD to mount disks. There are other
devices which are not disks. In fact there are USB<->SCSI bridges, so
you could do everything SCSI can do, eg. attach an old scanner which needs
only SG.

	Regards
		Oliver

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]


> So if you want to use USB Mass Storage devices (that use SCSI emulation) you 
> need also SCSI disk support (I have realized it when I've tried to mount 
> one those USB devices, without success).

... but I only want to use USB cdroms ;)



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fix dependeces for CONFIG_USB_STORAGE

[Paolo Ornati]

On Wednesday 02 June 2004 13:52, Christoph Hellwig wrote:
> On Wed, Jun 02, 2004 at 01:52:14PM +0200, Paolo Ornati wrote:
> > So if you want to use USB Mass Storage devices (that use SCSI
> > emulation) you need also SCSI disk support (I have realized it when
> > I've tried to mount one those USB devices, without success).
>
> There's also external usb cdrom enclosures.  In which case you only need
> sr.

ok... you are right...

Consequently this help could be a bit more explicit:

config USB_STORAGE
        tristate "USB Mass Storage support"
        depends on USB
        select SCSI
        ---help---
          Say Y here if you want to connect USB mass storage devices to your
          computer's USB port. This is the driver you need for USB floppy 
drives,
          USB hard disks, USB tape drives and USB CD-ROMs, along with
          similar devices. This driver may also be used for some cameras and
          card readers.

For example we can add something like this:
NOTE that these devices use SCSI emulation, so remember to enable the needed 
support in "SCSI Devices" section (for example: enable "SCSI Disk Support" 
if you are going to use USB hard drives).

;-)

-- 
	Paolo Ornati
	Linux v2.6.6