From: Arjan van de Ven <arjanv@redhat.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Chris Wright <chrisw@osdl.org>,
linux-kernel@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH] ALSA: Remove subsystem-specific malloc (1/8)
Date: Wed, 09 Jun 2004 22:21:26 +0200 [thread overview]
Message-ID: <1086812486.2810.21.camel@laptop.fenrus.com> (raw)
In-Reply-To: <1086812001.13026.63.camel@cherry>
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
> + */
> +void *kcalloc(size_t n, size_t size, int flags)
> +{
> + void *ret = kmalloc(n * size, flags);
how about making sure n*size doesn't overflow an int in this function?
We had a few security holes due to that happening a while ago; might as
well prevent it from happening entirely
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-09 20:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 21:24 Pekka J Enberg
2004-06-09 18:34 ` Chris Wright
2004-06-09 20:13 ` Pekka Enberg
2004-06-09 20:21 ` Arjan van de Ven [this message]
2004-06-09 20:40 ` Valdis.Kletnieks
2004-06-09 20:57 ` Chris Wright
2004-06-09 20:57 ` Pekka Enberg
2004-06-09 20:59 ` Arjan van de Ven
2004-06-09 21:07 ` Pekka Enberg
2004-06-11 10:09 ` Takashi Iwai
2004-06-11 10:43 ` Pekka J Enberg
2004-06-11 10:53 ` Pekka J Enberg
2004-06-09 21:00 ` [PATCH] " Chris Wright
2004-06-09 21:18 ` Pekka Enberg
2004-06-10 5:08 ` dean gaudet
2004-06-10 12:32 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086812486.2810.21.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®