From: Chris Wright <chrisw@osdl.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: arjanv@redhat.com, Chris Wright <chrisw@osdl.org>,
linux-kernel@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH] ALSA: Remove subsystem-specific malloc (1/8)
Date: Wed, 9 Jun 2004 14:00:56 -0700 [thread overview]
Message-ID: <20040609140056.E21045@build.pdx.osdl.net> (raw)
In-Reply-To: <1086814663.13026.70.camel@cherry>; from penberg@cs.helsinki.fi on Wed, Jun 09, 2004 at 11:57:43PM +0300
* Pekka Enberg (penberg@cs.helsinki.fi) wrote:
> +void *kcalloc(size_t n, size_t size, int flags)
> +{
> + if (n != 0 && size > INT_MAX / n)
> + return NULL;
Yup, I forgot to add divide by zero check.
> + void *ret = kmalloc(n * size, flags);
This is only C99, and will make some compilers spit up warning.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-06-09 21:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 21:24 Pekka J Enberg
2004-06-09 18:34 ` Chris Wright
2004-06-09 20:13 ` Pekka Enberg
2004-06-09 20:21 ` Arjan van de Ven
2004-06-09 20:40 ` Valdis.Kletnieks
2004-06-09 20:57 ` Chris Wright
2004-06-09 20:57 ` Pekka Enberg
2004-06-09 20:59 ` Arjan van de Ven
2004-06-09 21:07 ` Pekka Enberg
2004-06-11 10:09 ` Takashi Iwai
2004-06-11 10:43 ` Pekka J Enberg
2004-06-11 10:53 ` Pekka J Enberg
2004-06-09 21:00 ` Chris Wright [this message]
2004-06-09 21:18 ` [PATCH] " Pekka Enberg
2004-06-10 5:08 ` dean gaudet
2004-06-10 12:32 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040609140056.E21045@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®