* PATCH: 2.6.7-rc3 drivers/scsi/megaraid.c: user/kernel pointer bugs
@ 2004-06-09 23:10 Robert T. Johnson
2004-06-10 1:52 ` viro
0 siblings, 1 reply; 2+ messages in thread
From: Robert T. Johnson @ 2004-06-09 23:10 UTC (permalink / raw)
To: linux-megaraid-devel; +Cc: Linux Kernel
Since arg is a user pointer, so are uioc_mimd and uiocp, and hence umc is
a user pointer. Thus reading umc->xferaddr requires dereferencing a user
pointer, which isn't safe. Let me know if you have any questions or I've
made an error.
Best,
Rob
--- linux-2.6.7-rc3-full/drivers/scsi/megaraid.c.orig Wed Jun 9 12:43:49 2004
+++ linux-2.6.7-rc3-full/drivers/scsi/megaraid.c Wed Jun 9 12:43:10 2004
@@ -3815,7 +3815,8 @@ mega_n_to_m(void *arg, megacmd_t *mc)
umc = MBOX_P(uiocp);
- upthru = (mega_passthru *)umc->xferaddr;
+ if (get_user(upthru, (mega_passthru **)&umc->xferaddr))
+ return (-EFAULT);
if( put_user(mc->status, (u8 *)&upthru->scsistatus) )
return (-EFAULT);
@@ -3831,7 +3832,8 @@ mega_n_to_m(void *arg, megacmd_t *mc)
umc = (megacmd_t *)uioc_mimd->mbox;
- upthru = (mega_passthru *)umc->xferaddr;
+ if (get_user(upthru, (mega_passthru **)&umc->xferaddr))
+ return (-EFAULT);
if( put_user(mc->status, (u8 *)&upthru->scsistatus) )
return (-EFAULT);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-10 1:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-09 23:10 PATCH: 2.6.7-rc3 drivers/scsi/megaraid.c: user/kernel pointer bugs Robert T. Johnson
2004-06-10 1:52 ` viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®