From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.8-rc4-bk] NFS oops on x86-64
Date: Fri, 13 Aug 2004 21:45:09 -0400 [thread overview]
Message-ID: <1092447909.4078.18.camel@lade.trondhjem.org> (raw)
In-Reply-To: <411D65B4.4030208@pobox.com>
På fr , 13/08/2004 klokka 21:07, skreiv Jeff Garzik:
> See attached... oops in BK-latest NFS client on x86-64. The oops is
> 100% reproducible, and occurs immediately (as soon as I access any
> portion of the mounted NFS filesystem; the mount itself succeeds).
>
Does reverting Willy's borken patch fix it? That patch was clearly never
actually tested before Linus applied it.
I can see 2 problems in the NFS code alone:
1) Replacing a test for whether or not O_APPEND and O_DIRECT are
*both* set with one that checks whether either is set.
2) Adding a wonderful check in nfs_open() that causes it to return
immediately if this new nfs_check_flags() returns 0 (i.e. OK).
GRRRR
Trond
next prev parent reply other threads:[~2004-08-14 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 1:07 Jeff Garzik
2004-08-14 1:45 ` Trond Myklebust [this message]
2004-08-14 2:21 ` Trond Myklebust
2004-08-14 2:24 ` Trond Myklebust
2004-08-14 2:42 ` Jeff Garzik
2004-08-14 3:23 ` [PATCH] " Jeff Garzik
2004-08-14 2:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092447909.4078.18.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®