From: Jeff Garzik <jgarzik@pobox.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Re: [2.6.8-rc4-bk] NFS oops on x86-64
Date: Fri, 13 Aug 2004 23:23:34 -0400 [thread overview]
Message-ID: <411D85B6.5070506@pobox.com> (raw)
In-Reply-To: <1092450265.4078.37.camel@lade.trondhjem.org>
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
Yep, the attached patch fixes NFS on both x86 and x86-64.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 467 bytes --]
===== fs/nfs/file.c 1.40 vs edited =====
--- 1.40/fs/nfs/file.c 2004-08-09 14:58:00 -04:00
+++ edited/fs/nfs/file.c 2004-08-13 22:54:01 -04:00
@@ -72,7 +72,7 @@
static int nfs_check_flags(int flags)
{
- if (flags & (O_APPEND | O_DIRECT))
+ if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))
return -EINVAL;
return 0;
@@ -89,7 +89,7 @@
int res;
res = nfs_check_flags(filp->f_flags);
- if (!res)
+ if (res)
return res;
lock_kernel();
next prev parent reply other threads:[~2004-08-14 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 1:07 Jeff Garzik
2004-08-14 1:45 ` Trond Myklebust
2004-08-14 2:21 ` Trond Myklebust
2004-08-14 2:24 ` Trond Myklebust
2004-08-14 2:42 ` Jeff Garzik
2004-08-14 3:23 ` Jeff Garzik [this message]
2004-08-14 2:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411D85B6.5070506@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®