From: Matthew Dobson <colpatch@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>, Paul Jackson <pj@sgi.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix comment in include/linux/nodemask.h
Date: Thu, 26 Aug 2004 15:43:31 -0700 [thread overview]
Message-ID: <1093560210.4769.7.camel@arrakis> (raw)
Andrew, here's a small comment fix for include/linux/nodemask.h. It's a
comment that is only relevant to cpumasks and accidentally got copied
over during my (failed) attempt to correctly post the nodemask code.
The patch just updates the comment to make sense for nodemasks.
Thanks!
-Matt
--- linux-2.6.9-rc1-mm1/include/linux/nodemask.h 2004-08-26 15:38:42.000000000 -0700
+++ linux-2.6.9-rc1-mm1/include/linux/nodemask.h.fixed 2004-08-26 15:39:04.000000000 -0700
@@ -69,12 +69,9 @@
*
* Subtlety:
* 1) The 'type-checked' form of node_isset() causes gcc (3.3.2, anyway)
- * to generate slightly worse code. Note for example the additional
- * 40 lines of assembly code compiling the "for each possible node"
- * loops buried in the disk_stat_read() macros calls when compiling
- * drivers/block/genhd.c (arch i386, CONFIG_SMP=y). So use a simple
- * one-line #define for node_isset(), instead of wrapping an inline
- * inside a macro, the way we do the other calls.
+ * to generate slightly worse code. So use a simple one-line #define
+ * for node_isset(), instead of wrapping an inline inside a macro, the
+ * way we do the other calls.
*/
#include <linux/kernel.h>
next reply other threads:[~2004-08-26 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 22:43 Matthew Dobson [this message]
2004-08-26 22:54 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093560210.4769.7.camel@arrakis \
--to=colpatch@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®