mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fix comment in include/linux/nodemask.h
@ 2004-08-26 22:43 Matthew Dobson
  2004-08-26 22:54 ` Paul Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew Dobson @ 2004-08-26 22:43 UTC (permalink / raw)
  To: Andrew Morton, Paul Jackson, LKML

Andrew, here's a small comment fix for include/linux/nodemask.h.  It's a
comment that is only relevant to cpumasks and accidentally got copied
over during my (failed) attempt to correctly post the nodemask code. 
The patch just updates the comment to make sense for nodemasks.

Thanks!

-Matt

--- linux-2.6.9-rc1-mm1/include/linux/nodemask.h	2004-08-26 15:38:42.000000000 -0700
+++ linux-2.6.9-rc1-mm1/include/linux/nodemask.h.fixed	2004-08-26 15:39:04.000000000 -0700
@@ -69,12 +69,9 @@
  *
  * Subtlety:
  * 1) The 'type-checked' form of node_isset() causes gcc (3.3.2, anyway)
- *    to generate slightly worse code.  Note for example the additional
- *    40 lines of assembly code compiling the "for each possible node"
- *    loops buried in the disk_stat_read() macros calls when compiling
- *    drivers/block/genhd.c (arch i386, CONFIG_SMP=y).  So use a simple
- *    one-line #define for node_isset(), instead of wrapping an inline
- *    inside a macro, the way we do the other calls.
+ *    to generate slightly worse code.  So use a simple one-line #define 
+ *    for node_isset(), instead of wrapping an inline inside a macro, the 
+ *    way we do the other calls.
  */
 
 #include <linux/kernel.h>



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix comment in include/linux/nodemask.h
  2004-08-26 22:43 [PATCH] Fix comment in include/linux/nodemask.h Matthew Dobson
@ 2004-08-26 22:54 ` Paul Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Jackson @ 2004-08-26 22:54 UTC (permalink / raw)
  To: colpatch; +Cc: akpm, linux-kernel

Matthew wrote:
> a small comment fix for include/linux/nodemask.h.  

Looks good.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-08-26 23:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-26 22:43 [PATCH] Fix comment in include/linux/nodemask.h Matthew Dobson
2004-08-26 22:54 ` Paul Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®