From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Mikael Pettersson <mikpe@csd.uu.se>,
drivers@neukum.org, marcelo.tosatti@cyclades.com,
sailer@ife.ee.ethz.ch,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.4.28-pre3] USB drivers gcc-3.4 fixes
Date: Mon, 13 Sep 2004 11:54:08 +0100 [thread overview]
Message-ID: <1095072845.14359.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20040912173018.44b9902f@lembas.zaitcev.lan>
On Llu, 2004-09-13 at 01:30, Pete Zaitcev wrote:
> > size -= pgrem;
> > - (char *)buffer += pgrem;
> > + buffer += pgrem;
>
> I'm pretty sure it's done that way on purpose. There were compilers which
> did not allow any arithmetics on void*, and it had to be cast to char*.
> So perhaps it's correct for 2.6, which requires gcc 3 anyway, but I have
> my doubts about applicability of this to 2.4.
Should be ok for the 2.* gcc we support. (BTW is anyone using anything
less than 2.95 nowdays because we've still got 2.7.* workarounds in
asm-i386/semaphore.h !)
Otherwise in "valid" C it's
buffer = ((char *)buffer) + pgrem;
next prev parent reply other threads:[~2004-09-13 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 11:29 Mikael Pettersson
2004-09-13 0:30 ` Pete Zaitcev
2004-09-13 10:54 ` Alan Cox [this message]
2004-09-13 3:49 ` Pete Zaitcev
2004-09-13 13:48 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095072845.14359.9.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=drivers@neukum.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mikpe@csd.uu.se \
--cc=sailer@ife.ee.ethz.ch \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®