From: Pete Zaitcev <zaitcev@redhat.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: alan@lxorguk.ukuu.org.uk, drivers@neukum.org,
marcelo.tosatti@cyclades.com, sailer@ife.ee.ethz.ch,
linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: [PATCH][2.4.28-pre3] USB drivers gcc-3.4 fixes
Date: Sun, 12 Sep 2004 17:30:18 -0700 [thread overview]
Message-ID: <20040912173018.44b9902f@lembas.zaitcev.lan> (raw)
In-Reply-To: <200409121129.i8CBT5Bo015222@harpo.it.uu.se>
On Sun, 12 Sep 2004 13:29:05 +0200 (MEST)
Mikael Pettersson <mikpe@csd.uu.se> wrote:
> This patch fixes gcc-3.4 cast-as-lvalue warnings in the 2.4.28-pre3
> kernel's USB drivers. The audio.c and uss720.c changes are backports
> from the 2.6 kernel. The hpusbscsi.c and microtek.c changes are new,
> since the 2.6 code is different.
> +++ linux-2.4.28-pre3/drivers/usb/audio.c 2004-09-12 01:56:20.000000000 +0200
> @@ -609,7 +609,7 @@
> size -= pgrem;
> - (char *)buffer += pgrem;
> + buffer += pgrem;
I'm pretty sure it's done that way on purpose. There were compilers which
did not allow any arithmetics on void*, and it had to be cast to char*.
So perhaps it's correct for 2.6, which requires gcc 3 anyway, but I have
my doubts about applicability of this to 2.4.
-- Pete
next prev parent reply other threads:[~2004-09-13 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 11:29 Mikael Pettersson
2004-09-13 0:30 ` Pete Zaitcev [this message]
2004-09-13 10:54 ` Alan Cox
2004-09-13 3:49 ` Pete Zaitcev
2004-09-13 13:48 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912173018.44b9902f@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=drivers@neukum.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mikpe@csd.uu.se \
--cc=sailer@ife.ee.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®