From: Mingming Cao <cmm@us.ibm.com>
To: Stephen Tweedie <sct@redhat.com>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
pbadari@us.ibm.com
Subject: [Patch 1/2]: ext3 reservation window size increase incorrectly fix
Date: 14 Sep 2004 17:20:33 -0700 [thread overview]
Message-ID: <1095207635.1637.22612.camel@w-ming2.beaverton.ibm.com> (raw)
In-Reply-To: <200409071302.i87D2bDf030921@sisko.scot.redhat.com>
Two ext3 reservation bug fixes.
In current reservation code (with or without the recent red-black tree
changes), when an existing old reservation is re-used as the new window
without adjusting it's position in the current per-filesystem tree, we
just need to update window's start and end block value, without any
remove/insert business. But we missed the the allocation hit ratio bit,
it is not reset.
Since this is the magic number used to determine whether the window size
should be doubled next time, this will cause the window size increase
incorrectly or too quickly.
Patch applies to 2.6.9-rc1-mm5, tested.
---
linux-2.6.9-rc1-mm5-ming/fs/ext3/balloc.c | 1 +
1 files changed, 1 insertion(+)
diff -puN fs/ext3/balloc.c~ext3_reservation_window_hit_ratio_fix fs/ext3/balloc.c
--- linux-2.6.9-rc1-mm5/fs/ext3/balloc.c~ext3_reservation_window_hit_ratio_fix 2004-09-14 00:30:41.667359608 -0700
+++ linux-2.6.9-rc1-mm5-ming/fs/ext3/balloc.c 2004-09-14 00:34:19.170294136 -0700
@@ -945,6 +945,7 @@ found_rsv_window:
}
my_rsv->rsv_start = reservable_space_start;
my_rsv->rsv_end = my_rsv->rsv_start + size - 1;
+ atomic_set(&my_rsv->rsv_alloc_hit, 0);
if (my_rsv != prev_rsv) {
rsv_window_add(sb, my_rsv);
}
_
next prev parent reply other threads:[~2004-09-15 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 13:02 [Patch 4/6]: ext3 reservations: Turn ext3 per-sb reservations list into an rbtree Stephen Tweedie
2004-09-07 22:48 ` Andrew Morton
2004-09-08 18:05 ` Stephen C. Tweedie
2004-09-08 18:55 ` Mingming Cao
2004-09-15 0:20 ` Mingming Cao [this message]
2004-09-15 0:20 ` [Patch 2/2]: ext3 reservations window allocation fix Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095207635.1637.22612.camel@w-ming2.beaverton.ibm.com \
--to=cmm@us.ibm.com \
--cc=akpm@osdl.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®