From: Nigel Cunningham <ncunningham@linuxmail.org>
To: arjanv@redhat.com
Cc: Andrew Morton <akpm@digeo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Suspend2 merge: New exports.
Date: Thu, 16 Sep 2004 21:54:09 +1000 [thread overview]
Message-ID: <1095335648.4883.230.camel@laptop.cunninghams> (raw)
In-Reply-To: <1095334846.2698.13.camel@laptop.fenrus.com>
Hi.
On Thu, 2004-09-16 at 21:40, Arjan van de Ven wrote:
> On Thu, 2004-09-16 at 13:20, Nigel Cunningham wrote:
>
> >
> > +EXPORT_SYMBOL(tainted);
>
> uhhhhh why do you need this in a module ?????
>
> most of these exports look REALLY fishy to me.
I'm marking the kernel as tainted when we've suspended. It could
probably be dropped but I was erring on the side of paranoia.
As to the others, I'll be happy to explain how they're used and drop
them if necessary/possible. I agree about a couple. The keyboard sound
one, for example, slipped past my purge of some
report-progress-while-beeping code I inherited.
Regards,
Nigel
--
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901
Many today claim to be tolerant. True tolerance, however, can cope with others
being intolerant.
next prev parent reply other threads:[~2004-09-16 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 11:20 Nigel Cunningham
2004-09-16 11:40 ` Arjan van de Ven
2004-09-16 11:54 ` Nigel Cunningham [this message]
2004-09-16 14:33 ` Greg KH
2004-09-16 22:04 ` Nigel Cunningham
2004-09-17 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095335648.4883.230.camel@laptop.cunninghams \
--to=ncunningham@linuxmail.org \
--cc=akpm@digeo.com \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®