From: Greg KH <greg@kroah.com>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@digeo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Suspend2 merge: New exports.
Date: Thu, 16 Sep 2004 07:33:22 -0700 [thread overview]
Message-ID: <20040916143322.GB32352@kroah.com> (raw)
In-Reply-To: <1095333619.3327.189.camel@laptop.cunninghams>
On Thu, Sep 16, 2004 at 09:20:19PM +1000, Nigel Cunningham wrote:
>
> This patch adds exports for functions used by suspend2. Needed, of
> course, when suspend is compiled as modules.
Why even allow suspend as a module? It seems like a pretty core chunk
of code that should be present all the time.
> diff -ruN linux-2.6.9-rc1/fs/buffer.c software-suspend-linux-2.6.9-rc1-rev3/fs/buffer.c
> --- linux-2.6.9-rc1/fs/buffer.c 2004-09-07 21:58:52.000000000 +1000
> +++ software-suspend-linux-2.6.9-rc1-rev3/fs/buffer.c 2004-09-09 19:36:24.000000000 +1000
> @@ -2916,7 +2975,7 @@
> *
> * try_to_free_buffers() is non-blocking.
> */
> -static inline int buffer_busy(struct buffer_head *bh)
> +inline int buffer_busy(struct buffer_head *bh)
> {
> return atomic_read(&bh->b_count) |
> (bh->b_state & ((1 << BH_Dirty) | (1 << BH_Lock)));
Why this change? buffer_busy() is not exported now.
> diff -ruN linux-2.6.9-rc1/fs/ioctl.c software-suspend-linux-2.6.9-rc1-rev3/fs/ioctl.c
> --- linux-2.6.9-rc1/fs/ioctl.c 2004-09-07 21:58:53.000000000 +1000
> +++ software-suspend-linux-2.6.9-rc1-rev3/fs/ioctl.c 2004-09-09 19:36:24.000000000 +1000
> @@ -138,8 +138,7 @@
>
> /*
> * Platforms implementing 32 bit compatibility ioctl handlers in
> - * modules need this exported
> + * modules need this exported. So does Suspend2 (when made as
> + * modules), so the export_symbol is now unconditional.
> */
> -#ifdef CONFIG_COMPAT
> EXPORT_SYMBOL(sys_ioctl);
> -#endif
What ioctls does suspend2 call? That seems very strange.
> diff -ruN linux-2.6.9-rc1/kernel/panic.c software-suspend-linux-2.6.9-rc1-rev3/kernel/panic.c
> --- linux-2.6.9-rc1/kernel/panic.c 2004-09-07 21:59:00.000000000 +1000
> +++ software-suspend-linux-2.6.9-rc1-rev3/kernel/panic.c 2004-09-09 19:36:24.000000000 +1000
> @@ -18,12 +18,14 @@
> #include <linux/sysrq.h>
> #include <linux/syscalls.h>
> #include <linux/interrupt.h>
> +#include <linux/suspend.h>
> #include <linux/nmi.h>
>
> int panic_timeout;
> int panic_on_oops;
> int tainted;
>
> +EXPORT_SYMBOL(tainted);
> EXPORT_SYMBOL(panic_timeout);
>
> struct notifier_block *panic_notifier_list;
Why is the include needed here just to export a symbol (nevermind the
fact that we should never export tainted in the first place.)
thanks,
greg k-h
next prev parent reply other threads:[~2004-09-16 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 11:20 Nigel Cunningham
2004-09-16 11:40 ` Arjan van de Ven
2004-09-16 11:54 ` Nigel Cunningham
2004-09-16 14:33 ` Greg KH [this message]
2004-09-16 22:04 ` Nigel Cunningham
2004-09-17 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916143322.GB32352@kroah.com \
--to=greg@kroah.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®