Re: [PATCH] Suspend2 Merge: Driver model patches 2/2

[Nigel Cunningham <ncunningham@linuxmail.org>]

Hi.

On Fri, 2004-09-17 at 00:28, Greg KH wrote:
> On Thu, Sep 16, 2004 at 08:58:51PM +1000, Nigel Cunningham wrote:
> > 
> > This simple helper adds support for finding a class given its name. I
> > use this to locate the frame buffer drivers and move them to the
> > keep-alive tree while suspending other drivers.
> > 
> > +struct class * class_find(char * name)
> > +{
> > +	struct class * this_class;
> > +
> > +	if (!name)
> > +		return NULL;
> > +
> > +	list_for_each_entry(this_class, &class_subsys.kset.list, subsys.kset.kobj.entry) {
> > +		if (!(strcmp(this_class->name, name)))
> > +			return this_class;
> > +	}
> > +
> > +	return NULL;
> > +}
> 
> Ick, no.  I've been over this before with the fb people, and am not going
> to accept this patch (nevermind that it's broken...)  See the lkml
> archives for more info on why I don't like this.

Please excuse my ignorance but I don't see how it's broken (their patch
just fills in a field that was left blank previously), and this patch
just makes use of that change. What's the point to device_class if we
don't use it?

That said, I do agree with using Pavel's new enum that includes
_SNAPSHOT and can see that it's a cleaner way in that it requires less
knowledge on suspend's part of what it wants to stay alive.

Regards,

Nigel

-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Many today claim to be tolerant. True tolerance, however, can cope with others
being intolerant.