Re: [PATCH] Suspend2 Merge: Driver model patches 2/2

[Greg KH <greg@kroah.com>]

On Fri, Sep 17, 2004 at 08:49:07AM +1000, Nigel Cunningham wrote:
> Hi.
> 
> On Fri, 2004-09-17 at 08:35, Greg KH wrote:
> > > > Ick, no.  I've been over this before with the fb people, and am not going
> > > > to accept this patch (nevermind that it's broken...)  See the lkml
> > > > archives for more info on why I don't like this.
> > > 
> > > Please excuse my ignorance but I don't see how it's broken
> > 
> > This function, as written is very broken.  I will not accept it.  Not to
> 
> What's broken? (I want to learn what I've done wrong that I'm not
> seeing).

 - No locking when traversing the list.
 - Reference count needs to be bumped before returning a pointer to the
   object you found.

> > mention the fact that the functionality this function proposes to offer
> > is not needed either.
> > 
> > > (their patch just fills in a field that was left blank previously),
> > 
> > What patch?
> 
> Attached. Sorry if I wrongly assumed this was the patch you're talking
> about.

Ah, no, I've never seen this one, thanks.  But it looks sane, I don't
have a problem with it (sysfs will like it, it's not a suspend specific
patch at all.)

thanks,

greg k-h