From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] ppc32: Fix bogus return value in pmac_cpufreq.c
Date: Fri, 24 Sep 2004 10:17:17 +1000 [thread overview]
Message-ID: <1095985037.3832.17.camel@gaston> (raw)
Hi !
There's an obvious uninitialized return value in pmac_cpufreq, here's
a fix:
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
===== arch/ppc/platforms/pmac_cpufreq.c 1.15 vs edited =====
--- 1.15/arch/ppc/platforms/pmac_cpufreq.c 2004-09-14 10:23:16 +10:00
+++ edited/arch/ppc/platforms/pmac_cpufreq.c 2004-09-24 10:15:41 +10:00
@@ -301,7 +301,6 @@
static int __pmac do_set_cpu_speed(int speed_mode)
{
struct cpufreq_freqs freqs;
- int rc;
freqs.old = cur_freq;
freqs.new = (speed_mode == PMAC_CPU_HIGH_SPEED) ? hi_freq : low_freq;
@@ -315,7 +314,7 @@
cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
cur_freq = (speed_mode == PMAC_CPU_HIGH_SPEED) ? hi_freq : low_freq;
- return rc;
+ return 0;
}
static int __pmac pmac_cpufreq_verify(struct cpufreq_policy *policy)
reply other threads:[~2004-09-24 0:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095985037.3832.17.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®