* [PATCH] ppc32: Fix bogus return value in pmac_cpufreq.c
@ 2004-09-24 0:17 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2004-09-24 0:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, Linux Kernel list
Hi !
There's an obvious uninitialized return value in pmac_cpufreq, here's
a fix:
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
===== arch/ppc/platforms/pmac_cpufreq.c 1.15 vs edited =====
--- 1.15/arch/ppc/platforms/pmac_cpufreq.c 2004-09-14 10:23:16 +10:00
+++ edited/arch/ppc/platforms/pmac_cpufreq.c 2004-09-24 10:15:41 +10:00
@@ -301,7 +301,6 @@
static int __pmac do_set_cpu_speed(int speed_mode)
{
struct cpufreq_freqs freqs;
- int rc;
freqs.old = cur_freq;
freqs.new = (speed_mode == PMAC_CPU_HIGH_SPEED) ? hi_freq : low_freq;
@@ -315,7 +314,7 @@
cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
cur_freq = (speed_mode == PMAC_CPU_HIGH_SPEED) ? hi_freq : low_freq;
- return rc;
+ return 0;
}
static int __pmac pmac_cpufreq_verify(struct cpufreq_policy *policy)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-24 0:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-24 0:17 [PATCH] ppc32: Fix bogus return value in pmac_cpufreq.c Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®