* [PATCH] serial receive lockup fix
@ 2004-10-08 18:20 Paul Fulghum
0 siblings, 0 replies; only message in thread
From: Paul Fulghum @ 2004-10-08 18:20 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-kernel
Fix lockup caused by serial driver not clearing
receive interrupt if flip buffer becomes full.
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
--- a/drivers/char/serial.c 2004-09-29 09:08:35.000000000 -0500
+++ b/drivers/char/serial.c 2004-09-29 09:09:07.000000000 -0500
@@ -573,8 +573,19 @@
do {
if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
tty->flip.tqueue.routine((void *) tty);
- if (tty->flip.count >= TTY_FLIPBUF_SIZE)
+ if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
+ /* no room in flip buffer, discard rx FIFO contents to clear IRQ
+ * *FIXME* Hardware with auto flow control
+ * would benefit from leaving the data in the FIFO and
+ * disabling the rx IRQ until space becomes available.
+ */
+ do {
+ serial_inp(info, UART_RX);
+ icount->overrun++;
+ *status = serial_inp(info, UART_LSR);
+ } while ((*status & UART_LSR_DR) && (max_count-- > 0));
return; // if TTY_DONT_FLIP is set
+ }
}
ch = serial_inp(info, UART_RX);
*tty->flip.char_buf_ptr = ch;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-08 19:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-08 18:20 [PATCH] serial receive lockup fix Paul Fulghum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome