From: "Stephen C. Tweedie" <sct@redhat.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"ext2-devel@lists.sourceforge.net"
<ext2-devel@lists.sourceforge.net>, Andrew Morton <akpm@osdl.org>,
Stephen Tweedie <sct@redhat.com>
Subject: Re: [Ext2-devel] Ext3 -mm reservations code: is this fix really correct?
Date: 15 Oct 2004 23:20:26 +0100 [thread overview]
Message-ID: <1097878826.1968.162.camel@sisko.scot.redhat.com> (raw)
In-Reply-To: <1097872144.4591.54.camel@localhost.localdomain>
Hi,
On Fri, 2004-10-15 at 21:29, mingming cao wrote:
> How about this? Haven't test it, will do it shortly.:)
if ((my_rsv->rsv_start <= group_end_block) &&
- (my_rsv->rsv_end > group_end_block))
+ (my_rsv->rsv_end > group_end_block) &&
+ (start_block <= my_rsv->rsv_start))
return -1;
That new "<=" should be a ">=", shouldn't it?
Otherwise, looks OK.
--Stephen
next prev parent reply other threads:[~2004-10-15 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 13:27 Stephen C. Tweedie
2004-10-15 16:01 ` [Ext2-devel] " mingming cao
2004-10-15 16:40 ` Stephen C. Tweedie
2004-10-15 20:29 ` mingming cao
2004-10-15 22:20 ` Stephen C. Tweedie [this message]
2004-10-15 22:34 ` mingming cao
2004-10-18 22:55 ` [PATCH 2/3] ext3 reservation allow turn off for specifed file Mingming Cao
2004-10-18 23:42 ` Andrew Morton
2004-10-19 1:01 ` Mingming Cao
2004-10-20 17:55 ` Ray Lee
2004-10-25 20:33 ` [Ext2-devel] " Mingming Cao
2004-10-25 23:05 ` Mingming Cao
2004-10-25 23:45 ` Andrew Morton
2004-10-26 16:53 ` Mingming Cao
2004-10-26 20:18 ` Andrew Morton
2004-10-26 23:01 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097878826.1968.162.camel@sisko.scot.redhat.com \
--to=sct@redhat.com \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®