* [PATCH] Don't ignore try_stop_module return
@ 2004-11-01 7:01 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2004-11-01 7:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: lkml - Kernel Mailing List
Name: Fix Module Removal Bug: Don't Ignore try_stop_module Return
Status: Trivial
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Since 2.6.4 we've been ignoring the failure of try_stop_module: it
will normally fail if the module reference count is non-zero. This
would have been mainly unnoticed, since "modprobe -r" checks the usage
count before calling sys_delete_module(), however there is a race
which would cause a hang in this case.
Index: linux-2.6.10-rc1-bk10-Module/kernel/module.c
===================================================================
--- linux-2.6.10-rc1-bk10-Module.orig/kernel/module.c 2004-11-01 17:54:17.861349784 +1100
+++ linux-2.6.10-rc1-bk10-Module/kernel/module.c 2004-11-01 17:57:15.020417512 +1100
@@ -576,6 +576,8 @@
/* Stop the machine so refcounts can't move and disable module. */
ret = try_stop_module(mod, flags, &forced);
+ if (ret != 0)
+ goto out;
/* Never wait if forced. */
if (!forced && module_refcount(mod) != 0)
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-11-02 9:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-01 7:01 [PATCH] Don't ignore try_stop_module return Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®