mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Thangaraj.S@microchip.com
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, Bryan.Whitehead@microchip.com,
	UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/5] net: lan743x: Add support to software-nodes for SFP
Date: Wed, 27 May 2026 15:29:25 +0200	[thread overview]
Message-ID: <10ada54c-43eb-4129-abc9-aa5b1b94bfb5@lunn.ch> (raw)
In-Reply-To: <DSWPR11MB97150CCAF4008FFA5193F5FDEC082@DSWPR11MB9715.namprd11.prod.outlook.com>

> > 
> > > +#define PCI11X1X_TX_FAULT_GPIO               46
> > > +#define PCI11X1X_TX_DIS_GPIO         47
> > > +#define PCI11X1X_RATE_SEL0_GPIO              48
> > > +#define PCI11X1X_LOS_GPIO            49
> > > +#define PCI11X1X_MOD_DEF0_GPIO               51
> > 
> > How do you know these values?
> > 
> > Can i buy this device, design my own board, and decide to use a different
> > mapping of GPIO pins to SFP cage pins? Or does the data sheet say you MUST
> > use this mapping?
> > 
> > Maybe consider drivers/misc/lan966x_pci.dtso.
> [Thangaraj Samynathan] ]  These values are from the Microchip EVB reference design,
> not mandated   by the datasheet. A board designer is free to wire SFP signals to
> different GPIO pins.
> 
> However, the PCI11x1x is a PCIe add-in card that can also be used in
> standard x86 systems. A .dtso overlay has no base DT to attach to on
> x86, and ACPI _DSD properties require the platform firmware vendor to
> add them - which is not realistic for a PCIe add-in card in the field.
> 
> We propose using the EVB default GPIO values as a fallback when no
> firmware description is present, and reading from DT/ACPI _DSD when
> available. Does this approach seem reasonable?

lan966x_pci.dtso can be used with a PCIe add in card. What is
important is that the PCI vendor/product ID represents the specific
board, so that the correct dtso file is loaded, which then has the
correct GPIO mappings.

The EVB documentation needs to be clear that the microchip
vendor/product should only be used when the board is 100% compatible
to the EVB, otherwise bad things will happen. Each OEM should use
their own values.

Or you need to stuff the complete configuration, including the GPIOs,
into the EEPROM/strapping pins.

      Andrew

  reply	other threads:[~2026-05-27 13:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 10:50 [PATCH v4 0/5] net: lan743x: Add SFP support for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 1/5] net: lan743x: rename is_sgmii_en to is_pcs_en Thangaraj Samynathan
2026-05-14 12:38   ` Andrew Lunn
2026-05-27  6:21     ` Thangaraj.S
2026-05-14 10:50 ` [PATCH v4 2/5] net: lan743x: read SFP straps from PCI11x1x device Thangaraj Samynathan
2026-05-14 12:47   ` Andrew Lunn
2026-05-27  7:08     ` Thangaraj.S
2026-05-27 13:23       ` Andrew Lunn
2026-06-01  6:10         ` Thangaraj.S
2026-06-01 12:41           ` Andrew Lunn
2026-06-05  0:10             ` Ronnie.Kunin
2026-05-14 10:50 ` [PATCH v4 3/5] net: lan743x: Add support to software-nodes for SFP Thangaraj Samynathan
2026-05-14 12:57   ` Andrew Lunn
2026-05-14 13:02     ` Andrew Lunn
2026-05-27  7:28     ` Thangaraj.S
2026-05-27 13:29       ` Andrew Lunn [this message]
2026-05-14 10:50 ` [PATCH v4 4/5] net: lan743x: Register SFP platform device for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 5/5] net: lan743x: Add PCS/XPCS support for SFP on PCI11x1x Thangaraj Samynathan
2026-05-14 13:16   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10ada54c-43eb-4129-abc9-aa5b1b94bfb5@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Bryan.Whitehead@microchip.com \
    --cc=Thangaraj.S@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®