From: Andrew Lunn <andrew@lunn.ch>
To: Thangaraj.S@microchip.com
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Bryan.Whitehead@microchip.com,
UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] net: lan743x: read SFP straps from PCI11x1x device
Date: Wed, 27 May 2026 15:23:26 +0200 [thread overview]
Message-ID: <af49a018-952a-439a-8beb-2e300a1d266a@lunn.ch> (raw)
In-Reply-To: <DSWPR11MB971561B42BB157F7C8C436C2EC082@DSWPR11MB9715.namprd11.prod.outlook.com>
> > > Introduce CONFIG_LAN743X_SFP to guard SFP-specific code
> >
> > Why? Does this add a lot of code? Most MAC drivers don't have such a Kconfig
> > configuration, so i think this needs some justification.
> [Thangaraj Samynathan] CONFIG_LAN743X_SFP was introduced based on
> Jakub's v3 review feedback. There are devices on this LAN743x family
> of devices (LAN7430, LAN7431, PCI11x1x) that do not support SFP at
> all. So while the amount of code in the common LAN743x driver itself
> may not be that much, the dependencies could force an intended
> minimalistic build of the kernel that wanted to use the lan7430 device
> (which is rgmii only capable device) to have to include tons of kernel
> code (sfp, i2c, gpio) it does not need otherwise.
In practice distributions turn on nearly everything. So the code is
likely to be built. Rather than a Kconfig symbol, can you move the
code into a module, which only gets loaded for pci11x1x?
Andrew
next prev parent reply other threads:[~2026-05-27 13:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 10:50 [PATCH v4 0/5] net: lan743x: Add SFP support for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 1/5] net: lan743x: rename is_sgmii_en to is_pcs_en Thangaraj Samynathan
2026-05-14 12:38 ` Andrew Lunn
2026-05-27 6:21 ` Thangaraj.S
2026-05-14 10:50 ` [PATCH v4 2/5] net: lan743x: read SFP straps from PCI11x1x device Thangaraj Samynathan
2026-05-14 12:47 ` Andrew Lunn
2026-05-27 7:08 ` Thangaraj.S
2026-05-27 13:23 ` Andrew Lunn [this message]
2026-06-01 6:10 ` Thangaraj.S
2026-06-01 12:41 ` Andrew Lunn
2026-06-05 0:10 ` Ronnie.Kunin
2026-05-14 10:50 ` [PATCH v4 3/5] net: lan743x: Add support to software-nodes for SFP Thangaraj Samynathan
2026-05-14 12:57 ` Andrew Lunn
2026-05-14 13:02 ` Andrew Lunn
2026-05-27 7:28 ` Thangaraj.S
2026-05-27 13:29 ` Andrew Lunn
2026-05-14 10:50 ` [PATCH v4 4/5] net: lan743x: Register SFP platform device for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 5/5] net: lan743x: Add PCS/XPCS support for SFP on PCI11x1x Thangaraj Samynathan
2026-05-14 13:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af49a018-952a-439a-8beb-2e300a1d266a@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®