* [PATCH 1/1] gpio_keys.c: Send also event when EV_ABS axis button is released.
@ 2025-01-31 14:22 Marian Flor
0 siblings, 0 replies; 2+ messages in thread
From: Marian Flor @ 2025-01-31 14:22 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel
---
drivers/input/keyboard/gpio_keys.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 5eef66516e37..20a0327e8f9a 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -373,12 +373,10 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
return;
}
- if (type == EV_ABS) {
- if (state)
- input_event(input, type, button->code, button->value);
- } else {
+ if (type == EV_ABS)
+ input_event(input, type, button->code, state ? button->value : 0);
+ else
input_event(input, type, *bdata->code, state);
- }
}
static void gpio_keys_debounce_event(struct gpio_button_data *bdata)
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] gpio_keys.c: Send also event when EV_ABS axis button is released.
@ 2025-01-31 14:59 Ethan Carter Edwards
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Carter Edwards @ 2025-01-31 14:59 UTC (permalink / raw)
To: marian.flor; +Cc: linux-input, linux-kernel, dmitry.torokhov
Why is this needed? your subject is good, but add a commit description.
Any empty one doesn't tell us anything about what your code does or why
it is needed. What value does it bring to the users?
Thanks,
Ethan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-31 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-31 14:22 [PATCH 1/1] gpio_keys.c: Send also event when EV_ABS axis button is released Marian Flor
2025-01-31 14:59 Ethan Carter Edwards
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®