mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@kernel.org>, "Du, Fan" <fan.du@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"hch@lst.de" <hch@lst.de>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps
Date: Thu, 26 Oct 2017 07:25:37 -0700	[thread overview]
Message-ID: <10bc2525-fccc-81e6-1ec0-27d63cff89b4@intel.com> (raw)
In-Reply-To: <20171026141943.fsmd4goiec32qjkf@dhcp22.suse.cz>

On 10/26/2017 07:19 AM, Michal Hocko wrote:
>> Current vm_normal_page implementation doesn't pick up page with DEVMAP pfn.
>> The second patch fix this and export DAX mappings into counters introduced in the
>> first patch.
>>
>> IMO, the user care more about how much persistent memory they used, how about
>> a small tweak with smaps_account, and report the total mapping size into RSS/PSS,
>> which user are usually more familiar with?
> No! Rss and pss is already used by many tools to evaluate misbehaving
> tasks. If you start accounting the memory which is not bound to the
> process life time then you can break those usecases. This is the reason
> why hugetlb is not accounted to rss as well.

Yeah, folks (rightly) assume Rss is memory and eaten from MemTotal.  DAX
mappings do not use RAM.

  reply	other threads:[~2017-10-26 14:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25  0:27 Fan Du
2017-10-25  0:27 ` [PATCH 2/2] Add /proc/PID/{smaps, numa_maps} support for DAX Fan Du
2017-10-25  9:30   ` Michal Hocko
2017-10-25 17:14     ` Dave Hansen
2017-10-26 14:16       ` Michal Hocko
2017-10-26 14:24         ` Dave Hansen
2017-10-26 14:31           ` Michal Hocko
2017-10-26 14:51             ` Dave Hansen
2017-10-26 15:07               ` Michal Hocko
2017-10-26 15:56                 ` Dan Williams
2017-10-27  4:00               ` Du, Fan
2017-10-27 10:31                 ` Dan Williams
2017-10-28  2:07   ` kbuild test robot
2017-10-25  9:28 ` [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps Michal Hocko
2017-10-26  1:41   ` Du, Fan
2017-10-26  5:13     ` [PATCH v4] Add /proc/PID/smaps support for DAX Fan Du
2017-10-26  9:16       ` Dan Williams
2017-10-27  2:49         ` Du, Fan
2017-10-26 14:03       ` Dave Hansen
2017-10-27  2:47         ` Du, Fan
2017-10-27  8:07           ` Michal Hocko
2017-10-27  8:24             ` Du, Fan
2017-10-27  8:42               ` Michal Hocko
2017-10-27  9:03                 ` Du, Fan
2017-10-27  9:09                   ` Michal Hocko
2017-10-27  9:17                     ` Du, Fan
2017-10-27  9:26                       ` Michal Hocko
2017-10-27  9:34                 ` Du, Fan
2017-10-26 14:19     ` [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps Michal Hocko
2017-10-26 14:25       ` Dave Hansen [this message]
2017-10-29 14:19 ` [lkp-robot] [proc] eb948c71f7: WARNING:at_mm/hugetlb.c:#hugetlb_add_hstate kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10bc2525-fccc-81e6-1ec0-27d63cff89b4@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=fan.du@intel.com \
    --cc=hch@lst.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®