From: Michal Hocko <mhocko@kernel.org>
To: "Du, Fan" <fan.du@intel.com>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hch@lst.de" <hch@lst.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] Add /proc/PID/smaps support for DAX
Date: Fri, 27 Oct 2017 10:07:30 +0200 [thread overview]
Message-ID: <20171027080730.3532fpgcwbozewfv@dhcp22.suse.cz> (raw)
In-Reply-To: <5A90DA2E42F8AE43BC4A093BF06788481AA513E1@SHSMSX104.ccr.corp.intel.com>
On Fri 27-10-17 02:47:43, Du, Fan wrote:
>
>
> >-----Original Message-----
> >From: Hansen, Dave
> >Sent: Thursday, October 26, 2017 10:03 PM
> >To: Du, Fan <fan.du@intel.com>; akpm@linux-foundation.org; hch@lst.de;
> >Williams, Dan J <dan.j.williams@intel.com>; mhocko@kernel.org
> >Cc: linux-kernel@vger.kernel.org
> >Subject: Re: [PATCH v4] Add /proc/PID/smaps support for DAX
> >
> >I'm honestly not understanding what problem this solves. Could you,
> >perhaps, do a before and after of smaps with and without this patch?
>
> The motivation here is described in the commit message.
> ------------------------------------------------------------------------------------------
> Memory behind device DAX is not attached into normal memory
> management system, when user mmap /dev/dax, smaps part is
> currently missing, so no idea for user to check how much
> device DAX memory are actually used in practice.
This might be motivation but you are still not explaining _why_ that is
a problem. _Who_ is going to use that information and for _what_
purpose. This is really essential!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-10-27 8:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 0:27 [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps Fan Du
2017-10-25 0:27 ` [PATCH 2/2] Add /proc/PID/{smaps, numa_maps} support for DAX Fan Du
2017-10-25 9:30 ` Michal Hocko
2017-10-25 17:14 ` Dave Hansen
2017-10-26 14:16 ` Michal Hocko
2017-10-26 14:24 ` Dave Hansen
2017-10-26 14:31 ` Michal Hocko
2017-10-26 14:51 ` Dave Hansen
2017-10-26 15:07 ` Michal Hocko
2017-10-26 15:56 ` Dan Williams
2017-10-27 4:00 ` Du, Fan
2017-10-27 10:31 ` Dan Williams
2017-10-28 2:07 ` kbuild test robot
2017-10-25 9:28 ` [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps Michal Hocko
2017-10-26 1:41 ` Du, Fan
2017-10-26 5:13 ` [PATCH v4] Add /proc/PID/smaps support for DAX Fan Du
2017-10-26 9:16 ` Dan Williams
2017-10-27 2:49 ` Du, Fan
2017-10-26 14:03 ` Dave Hansen
2017-10-27 2:47 ` Du, Fan
2017-10-27 8:07 ` Michal Hocko [this message]
2017-10-27 8:24 ` Du, Fan
2017-10-27 8:42 ` Michal Hocko
2017-10-27 9:03 ` Du, Fan
2017-10-27 9:09 ` Michal Hocko
2017-10-27 9:17 ` Du, Fan
2017-10-27 9:26 ` Michal Hocko
2017-10-27 9:34 ` Du, Fan
2017-10-26 14:19 ` [PATCHv3 1/2] proc: mm: export PTE sizes directly in smaps Michal Hocko
2017-10-26 14:25 ` Dave Hansen
2017-10-29 14:19 ` [lkp-robot] [proc] eb948c71f7: WARNING:at_mm/hugetlb.c:#hugetlb_add_hstate kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027080730.3532fpgcwbozewfv@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=fan.du@intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®