* [PATCH] m68k: fix kunmap usage in pte_alloc_one
@ 2009-08-27 11:47 Heiko Carstens
2009-08-27 12:18 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2009-08-27 11:47 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Ungerer, Andrew Morton; +Cc: linux-kernel
Subject: [PATCH] m68k: avoid pgprot_noncached redefinition
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Compiling m68k with defconfig gives a lot of these warnings:
In file included from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgalloc.h:13,
from arch/m68k/kernel/dma.c:15:
arch/m68k/include/asm/motorola_pgalloc.h: In function 'pte_alloc_one':
arch/m68k/include/asm/motorola_pgalloc.h:44: warning: passing argument 1 of 'kunmap' from incompatible pointer type
kunmap wants a page not a pte.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
arch/m68k/include/asm/motorola_pgalloc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/m68k/include/asm/motorola_pgalloc.h
===================================================================
--- linux-2.6.orig/arch/m68k/include/asm/motorola_pgalloc.h
+++ linux-2.6/arch/m68k/include/asm/motorola_pgalloc.h
@@ -41,7 +41,7 @@ static inline pgtable_t pte_alloc_one(st
flush_tlb_kernel_page(pte);
nocache_page(pte);
}
- kunmap(pte);
+ kunmap(page);
pgtable_page_ctor(page);
return page;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] m68k: fix kunmap usage in pte_alloc_one
2009-08-27 11:47 [PATCH] m68k: fix kunmap usage in pte_alloc_one Heiko Carstens
@ 2009-08-27 12:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2009-08-27 12:18 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Greg Ungerer, Andrew Morton, linux-kernel
On Thu, Aug 27, 2009 at 13:47, Heiko Carstens<heiko.carstens@de.ibm.com> wrote:
> Subject: [PATCH] m68k: avoid pgprot_noncached redefinition
>
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Compiling m68k with defconfig gives a lot of these warnings:
>
> In file included from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgalloc.h:13,
> from arch/m68k/kernel/dma.c:15:
> arch/m68k/include/asm/motorola_pgalloc.h: In function 'pte_alloc_one':
> arch/m68k/include/asm/motorola_pgalloc.h:44: warning: passing argument 1 of 'kunmap' from incompatible pointer type
>
> kunmap wants a page not a pte.
Thanks, but Linus has just pulled the fix last night.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-27 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-27 11:47 [PATCH] m68k: fix kunmap usage in pte_alloc_one Heiko Carstens
2009-08-27 12:18 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®