From: Martin Josefsson <gandalf@wlug.westbo.se>
To: perex@suse.cz
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Add pci_save_state() to ALSA
Date: Thu, 11 Nov 2004 21:39:46 +0100 [thread overview]
Message-ID: <1100205586.6496.31.camel@tux.rsn.bth.se> (raw)
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi
Some time ago, a patch was merged that removed pci_save_state() and
pci_restore_state() from various drivers. That patch also added
pci_restore_state() to sound/core/init.c but didn't add pci_save_state()
anywhere.
My laptop doesn't resume (gets what I assume is an ACPI timeout and
hangs solid) without this small obvious patch.
Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
--- linux-2.6.10-rc1-bk21.orig/sound/core/init.c 2004-11-11 18:51:17.000000000 +0100
+++ linux-2.6.10-rc1-bk21/sound/core/init.c 2004-11-11 20:57:52.000000000 +0100
@@ -789,6 +789,8 @@ int snd_card_pci_suspend(struct pci_dev
return 0;
if (card->power_state == SNDRV_CTL_POWER_D3hot)
return 0;
+ /* save the PCI config space */
+ pci_save_state(dev);
/* FIXME: correct state value? */
return card->pm_suspend(card, 0);
}
--
/Martin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-11-11 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 20:39 Martin Josefsson [this message]
2004-11-12 9:22 ` Takashi Iwai
2004-11-12 13:00 Zhu, Yi
2004-11-12 13:26 ` Takashi Iwai
2004-11-12 13:45 ` Arjan van de Ven
2004-11-12 13:58 ` Takashi Iwai
2004-11-12 16:12 ` Martin Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100205586.6496.31.camel@tux.rsn.bth.se \
--to=gandalf@wlug.westbo.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®