From: Arjan van de Ven <arjan@infradead.org>
To: Li Shaohua <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH]eepro100 resume failure
Date: Mon, 15 Nov 2004 09:43:47 +0100 [thread overview]
Message-ID: <1100508226.2936.11.camel@laptop.fenrus.org> (raw)
In-Reply-To: <1100507449.31599.9.camel@sli10-desk.sh.intel.com>
>
> @@ -2337,7 +2337,12 @@ static int eepro100_resume(struct pci_de
> struct speedo_private *sp = netdev_priv(dev);
> long ioaddr = dev->base_addr;
>
> + pci_set_power_state(pdev, 0);
> pci_restore_state(pdev);
> + if (pdev->is_enabled)
> + pci_enable_device(pdev);
> + if (pdev->is_busmaster)
> + pci_set_master(pdev);
this is wrong; the driver should KNOW the device is enabled; no reason
to check for is_enabled. Same for is_busmaster...
next prev parent reply other threads:[~2004-11-15 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 8:30 Li Shaohua
2004-11-15 8:43 ` Arjan van de Ven [this message]
2004-11-15 8:46 ` Li Shaohua
2004-11-15 8:58 ` Arjan van de Ven
2004-11-15 8:54 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100508226.2936.11.camel@laptop.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®