mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Shaohua <shaohua.li@intel.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH]eepro100 resume failure
Date: Mon, 15 Nov 2004 16:54:51 +0800	[thread overview]
Message-ID: <1100508891.32025.5.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <1100509081.2936.13.camel@laptop.fenrus.org>

On Mon, 2004-11-15 at 16:58, Arjan van de Ven wrote:
> > +	pci_set_power_state(pdev, 0);
> >  	pci_restore_state(pdev);
> > +	pci_enable_device(pdev);
> > +	pci_set_master(pdev);
> >  
> 
> one more nitpick; pci_enable_device() already calls
> pci_set_power_state()... isn't that double up now ?
> 
I think 'pci_restore_state' should be called after
'pci_set_power_state'.

Thanks,
Shaohua


      reply	other threads:[~2004-11-15  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-15  8:30 Li Shaohua
2004-11-15  8:43 ` Arjan van de Ven
2004-11-15  8:46   ` Li Shaohua
2004-11-15  8:58     ` Arjan van de Ven
2004-11-15  8:54       ` Li Shaohua [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100508891.32025.5.camel@sli10-desk.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®