From: John Kacur <jkacur@redhat.com>
To: Wenji Huang <wenji.huang@oracle.com>
Cc: fweisbec@gmail.com, acme@redhat.com, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: make cmd_to_page function compact
Date: Wed, 13 Jan 2010 08:28:35 -0500 (EST) [thread overview]
Message-ID: <110235132.210191263389315584.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <969870729.210151263389292546.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
----- "Wenji Huang" <wenji.huang@oracle.com> wrote:
> Remove branch for is_perf_command
>
> Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
> ---
> tools/perf/builtin-help.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index 9f810b1..65e2691 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -314,8 +314,6 @@ static const char *cmd_to_page(const char
> *perf_cmd)
> return "perf";
> else if (!prefixcmp(perf_cmd, "perf"))
> return perf_cmd;
> - else if (is_perf_command(perf_cmd))
> - return prepend("perf-", perf_cmd);
> else
> return prepend("perf-", perf_cmd);
> }
> --
> 1.5.6
Thanks, Wenji, I tested your change, and it works find.
Acked-by: John Kacur <jkacur@redhat.com>
next parent reply other threads:[~2010-01-13 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <969870729.210151263389292546.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-01-13 13:28 ` John Kacur [this message]
2010-01-13 9:01 Wenji Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110235132.210191263389315584.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=jkacur@redhat.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®