* Re: [PATCH] perf: make cmd_to_page function compact
[not found] <969870729.210151263389292546.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
@ 2010-01-13 13:28 ` John Kacur
0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2010-01-13 13:28 UTC (permalink / raw)
To: Wenji Huang; +Cc: fweisbec, acme, mingo, linux-kernel
----- "Wenji Huang" <wenji.huang@oracle.com> wrote:
> Remove branch for is_perf_command
>
> Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
> ---
> tools/perf/builtin-help.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index 9f810b1..65e2691 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -314,8 +314,6 @@ static const char *cmd_to_page(const char
> *perf_cmd)
> return "perf";
> else if (!prefixcmp(perf_cmd, "perf"))
> return perf_cmd;
> - else if (is_perf_command(perf_cmd))
> - return prepend("perf-", perf_cmd);
> else
> return prepend("perf-", perf_cmd);
> }
> --
> 1.5.6
Thanks, Wenji, I tested your change, and it works find.
Acked-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] perf: make cmd_to_page function compact
@ 2010-01-13 9:01 Wenji Huang
0 siblings, 0 replies; 2+ messages in thread
From: Wenji Huang @ 2010-01-13 9:01 UTC (permalink / raw)
To: linux-kernel; +Cc: fweisbec, jkacur, acme, mingo, Wenji Huang
Remove branch for is_perf_command
Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
---
tools/perf/builtin-help.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index 9f810b1..65e2691 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -314,8 +314,6 @@ static const char *cmd_to_page(const char *perf_cmd)
return "perf";
else if (!prefixcmp(perf_cmd, "perf"))
return perf_cmd;
- else if (is_perf_command(perf_cmd))
- return prepend("perf-", perf_cmd);
else
return prepend("perf-", perf_cmd);
}
--
1.5.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-13 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <969870729.210151263389292546.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-01-13 13:28 ` [PATCH] perf: make cmd_to_page function compact John Kacur
2010-01-13 9:01 Wenji Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®