mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Rose <johnrose@austin.ibm.com>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: Greg KH <greg@kroah.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] release_pcibus_dev() crash
Date: Thu, 13 Jan 2005 11:49:11 -0600	[thread overview]
Message-ID: <1105638551.30960.16.camel@sinatra.austin.ibm.com> (raw)
In-Reply-To: <200501130933.59041.jbarnes@engr.sgi.com>

> Maybe, did you read Documentation/filesystems/sysfs-pci.c?  You need to do 
> more than just enable HAVE_PCI_LEGACY, you also need to implement some 
> functions.

This sounds like more than I bargained for.  I'll leave the patch as-is,
since I don't currently have the means to test a fix for the legacy IO
stuff.  Also because it doesn't crash on my architecture :)

If you get some time, my suggestion is to scrap
pci_remove_legacy_files(), and free the pci_bus->legacy_io field in
pci_remove_bus().  The binary sysfs files will be cleaned up
automatically as the class device is deleted, as described in the
parent.

Thanks-
John


  reply	other threads:[~2005-01-13 17:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-13  0:39 John Rose
2005-01-13  0:55 ` Jesse Barnes
2005-01-13 17:11   ` John Rose
2005-01-13 17:33     ` Jesse Barnes
2005-01-13 17:49       ` John Rose [this message]
2005-01-13 18:18         ` Greg KH
2005-01-13 18:21           ` Jesse Barnes
2005-01-13 18:37             ` Greg KH
2005-01-13 20:12               ` John Rose
2005-01-13 20:25                 ` Greg KH
2005-01-13 20:54                   ` John Rose
2005-01-13 21:05                     ` Greg KH
2005-01-13 21:17                       ` John Rose
2005-01-13 21:55                         ` John Rose
2005-01-13 23:41                         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105638551.30960.16.camel@sinatra.austin.ibm.com \
    --to=johnrose@austin.ibm.com \
    --cc=greg@kroah.com \
    --cc=jbarnes@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome