From: Jesse Barnes <jbarnes@engr.sgi.com>
To: John Rose <johnrose@austin.ibm.com>
Cc: Greg KH <greg@kroah.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] release_pcibus_dev() crash
Date: Wed, 12 Jan 2005 16:55:42 -0800 [thread overview]
Message-ID: <200501121655.42947.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1105576756.8062.17.camel@sinatra.austin.ibm.com>
On Wednesday, January 12, 2005 4:39 pm, John Rose wrote:
> The removal of the class device from sysfs is carried out explicitly by
> class_device_del(), which occurs prior to class_device_put(). The class
> device is gone from sysfs by the time class_device_put() is called. As
> such, this release function should not carry out sysfs cleanups for the
> class device.
>
> I'm unsure how pci_remove_legacy_files() doesn't cause the same crash for
> those who implemented it, but I'll leave that alone for now.
Feel free to fix it too. I haven't tested the removal case, so thanks for
catching it.
Jesse
next prev parent reply other threads:[~2005-01-13 1:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 0:39 John Rose
2005-01-13 0:55 ` Jesse Barnes [this message]
2005-01-13 17:11 ` John Rose
2005-01-13 17:33 ` Jesse Barnes
2005-01-13 17:49 ` John Rose
2005-01-13 18:18 ` Greg KH
2005-01-13 18:21 ` Jesse Barnes
2005-01-13 18:37 ` Greg KH
2005-01-13 20:12 ` John Rose
2005-01-13 20:25 ` Greg KH
2005-01-13 20:54 ` John Rose
2005-01-13 21:05 ` Greg KH
2005-01-13 21:17 ` John Rose
2005-01-13 21:55 ` John Rose
2005-01-13 23:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501121655.42947.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=greg@kroah.com \
--cc=johnrose@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome