From: James Bottomley <James.Bottomley@SteelEye.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
sam@ravnborg.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix broken cross compiles
Date: Tue, 25 Jan 2005 17:16:23 -0600 [thread overview]
Message-ID: <1106694984.6434.54.camel@mulgrave> (raw)
This patch:
kbuild: Use -isystem `gcc -print-file-name=include`
broke our parisc crosscompile (and presumably everyone else's).
The reason is that you have a := in the NOSTDINC_FLAGS rule, which is
evaluated in situ (i.e. before we've had a chance to set CROSSCOMPILE on
CC) so the gcc include path is actually the native one not the
crosscompiler one. On parisc this causes us to be unable to handle
_builtin_va functions, but I bet there are a heap of other problems.
The fix is below
James
===== Makefile 1.561 vs edited =====
--- 1.561/Makefile 2005-01-21 19:45:34 -06:00
+++ edited/Makefile 2005-01-25 17:13:51 -06:00
@@ -331,7 +331,7 @@
PERL = perl
CHECK = sparse
-NOSTDINC_FLAGS := -nostdinc -isystem $(shell $(CC) -print-file-name=include)
+NOSTDINC_FLAGS = -nostdinc -isystem $(shell $(CC) -print-file-name=include)
CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__
CHECKFLAGS += $(NOSTDINC_FLAGS)
MODFLAGS = -DMODULE
reply other threads:[~2005-01-26 1:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106694984.6434.54.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®