mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fix broken cross compiles
@ 2005-01-25 23:16 James Bottomley
  0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2005-01-25 23:16 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton, sam; +Cc: Linux Kernel

This patch:

kbuild: Use -isystem `gcc -print-file-name=include`

broke our parisc crosscompile (and presumably everyone else's).

The reason is that you have a := in the NOSTDINC_FLAGS rule, which is
evaluated in situ (i.e. before we've had a chance to set CROSSCOMPILE on
CC) so the gcc include path is actually the native one not the
crosscompiler one.  On parisc this causes us to be unable to handle
_builtin_va functions, but I bet there are a heap of other problems.

The fix is below

James

===== Makefile 1.561 vs edited =====
--- 1.561/Makefile	2005-01-21 19:45:34 -06:00
+++ edited/Makefile	2005-01-25 17:13:51 -06:00
@@ -331,7 +331,7 @@
 PERL		= perl
 CHECK		= sparse
 
-NOSTDINC_FLAGS := -nostdinc -isystem $(shell $(CC) -print-file-name=include)
+NOSTDINC_FLAGS  = -nostdinc -isystem $(shell $(CC) -print-file-name=include)
 CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__
 CHECKFLAGS     += $(NOSTDINC_FLAGS)
 MODFLAGS	= -DMODULE



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-01-26  1:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-25 23:16 [PATCH] fix broken cross compiles James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®