From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Claudiu <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<yoshihiro.shimoda.uh@renesas.com>,
<wsa+renesas@sang-engineering.com>,
<mitsuhiro.kimura.kc@renesas.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net v2 1/1] net: ravb: Wait for operation mode to be applied
Date: Sat, 23 Dec 2023 22:43:33 +0300 [thread overview]
Message-ID: <110a8720-e7a6-ebf1-b286-4834dc32651c@omp.ru> (raw)
In-Reply-To: <20231222113552.2049088-2-claudiu.beznea.uj@bp.renesas.com>
On 12/22/23 2:35 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> CSR.OPS bits specify the current operating mode and (according to
> documentation) they are updated by HW when the operating mode change
> request is processed. To comply with this check CSR.OPS before proceeding.
>
> Commit introduces ravb_set_opmode() that does all the necessities for
> setting the operating mode (set DMA.CCC and wait for CSR.OPS) and call it
What's DMA.CCC? Maybe CCC.OPC?
> where needed. This should comply with all the HW manuals requirements as
> different manual variants specify that different modes need to be checked
> in CSR.OPS when setting DMA.CCC.
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
[...]
MBR, Sergey
prev parent reply other threads:[~2023-12-23 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 11:35 [PATCH net v2 0/1] net: ravb: fixes for the ravb driver Claudiu
2023-12-22 11:35 ` [PATCH net v2 1/1] net: ravb: Wait for operation mode to be applied Claudiu
2023-12-23 19:39 ` Sergey Shtylyov
2023-12-27 10:10 ` claudiu beznea
2023-12-27 10:43 ` claudiu beznea
2023-12-28 19:07 ` Sergey Shtylyov
2023-12-29 15:07 ` claudiu beznea
2024-01-01 20:49 ` Sergey Shtylyov
2023-12-23 19:43 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110a8720-e7a6-ebf1-b286-4834dc32651c@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®