From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, yoshihiro.shimoda.uh@renesas.com,
wsa+renesas@sang-engineering.com,
mitsuhiro.kimura.kc@renesas.com
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net v2 1/1] net: ravb: Wait for operation mode to be applied
Date: Wed, 27 Dec 2023 12:43:50 +0200 [thread overview]
Message-ID: <1404c7ee-c9dd-4f2d-8f1d-d87310ceab8e@tuxon.dev> (raw)
In-Reply-To: <d5448a91-a4d8-444d-9f96-083049b1e33e@tuxon.dev>
On 27.12.2023 12:10, claudiu beznea wrote:
>>> -static int ravb_config(struct net_device *ndev)
>>> +static int ravb_set_opmode(struct net_device *ndev, u32 opmode)
>> Since you pass the complete CCC register value below, you should
>> rather call the function ravb_set_ccc() and call the parameter opmode
>> ccc.
> This will be confusing. E.g., if renaming it ravb_set_ccc() one would
> expect to set any fields of CCC though this function but this is not true
> as ravb_modify() in this function masks only CCC_OPC. The call of:
What about ravb_set_opc() or ravb_set_ccc_opc() ?
next prev parent reply other threads:[~2023-12-27 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 11:35 [PATCH net v2 0/1] net: ravb: fixes for the ravb driver Claudiu
2023-12-22 11:35 ` [PATCH net v2 1/1] net: ravb: Wait for operation mode to be applied Claudiu
2023-12-23 19:39 ` Sergey Shtylyov
2023-12-27 10:10 ` claudiu beznea
2023-12-27 10:43 ` claudiu beznea [this message]
2023-12-28 19:07 ` Sergey Shtylyov
2023-12-29 15:07 ` claudiu beznea
2024-01-01 20:49 ` Sergey Shtylyov
2023-12-23 19:43 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404c7ee-c9dd-4f2d-8f1d-d87310ceab8e@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®